issue #19 #23
Open
issue #19 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrote one of possible problem solutions - added calls to ::Plotrb::Base.classify method to Mark and Scale classes (to camelcase field names), fixed tests. Another solution would be to remove classify methods from base.rb completely (it turned out that this method also downcases first letter, so after removing camelcase problem remains until this is also removed, thus making classify method useless).
|
@zuhao Please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrote one of possible problem solutions - added calls to ::Plotrb::Base.classify method to Mark and Scale classes (to camelcase field names), fixed tests. Another solution would be to remove classify methods from base.rb completely (it turned out that this method also downcases first letter, so after removing camelcase problem remains until this is also removed, thus making classify method useless).