Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added custom CSS in highcharts #93

Merged
merged 11 commits into from
Jul 6, 2018
Merged

Added custom CSS in highcharts #93

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6011a91
Added custom CSS in highcharts
Prakriti-nith May 22, 2018
10322c0
Resolved errors
Prakriti-nith May 23, 2018
604402d
Added a test
Prakriti-nith May 25, 2018
4ccd61d
Added more examples
Prakriti-nith May 26, 2018
6c742b6
Separate method init_css
Prakriti-nith May 26, 2018
843183b
Improved documentation
Prakriti-nith May 29, 2018
3048dfa
Updated CSS examples in (data, opts) formats and checked all examples
Prakriti-nith Jun 16, 2018
0dcf84e
Corrected line length
Prakriti-nith Jun 16, 2018
bcdc049
Fix a typo
Prakriti-nith Jun 22, 2018
4814bbb
Added init_code method
Prakriti-nith Jun 27, 2018
4dd8a75
Change init_code to init_script
Prakriti-nith Jul 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ AllCops:
- 'Guardfile'
- '**/*.erb'
- '**/*.js'
- '**/*.css'
- 'spec/*'
- 'spec/**/*'
- 'vendor/**/*'
Expand Down
5 changes: 4 additions & 1 deletion lib/daru/view.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,10 @@ def dependent_script(lib=:nyaplot)
when :nyaplot
Nyaplot.init_script
when :highcharts
LazyHighCharts.init_script
init_code = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must have one class method, which will return init_css and init_script.
So we can use the same class method here as well.
DRY and Loose Coupling concepts should be applied.

init_code << LazyHighCharts.init_css
init_code << LazyHighCharts.init_script
init_code
when :googlecharts
GoogleVisualr.init_script
when :datatables
Expand Down
Loading