Rake task to add new adapter template #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prakriti-nith
force-pushed
the
rake_adapter
branch
from
008e73b
to
6c69e2e
Compare
Pull Request Test Coverage Report for Build 632
💛 - Coveralls |
Pull Request Test Coverage Report for Build 659
💛 - Coveralls |
Pull Request Test Coverage Report for Build 632
💛 - Coveralls |
lib/tasks/new_adapter.rake
Outdated
| template_code_str << "\n module #{file_name.capitalize}Adapter" | ||
| template_code_str << "\n extend self # rubocop:disable Style/ModuleFunction" | ||
| template_code_str << "\n def init(data, options, _user_options={})" | ||
| template_code_str << "\n # TODO" |
There was a problem hiding this comment.
After this raise not implemented exception.
lib/tasks/new_adapter.rake
Outdated
| template_code_str << "\n" | ||
| end | ||
|
|
||
| namespace :new do |
There was a problem hiding this comment.
Document this feature in readme.md (and wiki page once it is completed) explaining about API and useage.
|
Running this command: generates the following file in daru/view/adapters Running some code for this adapter results in NotImplementedError: |
| @@ -0,0 +1,57 @@ | |||
| def extract_adapter_template_code(file_name, template_code_str) | |||
There was a problem hiding this comment.
It is not good to have one single method that do all the things. We should have method to generate string for internal methods like init, export_html_file.
There are many ways to make it modular & extendable. Think/design good one.
Prakriti-nith
force-pushed
the
rake_adapter
branch
from
2033c64
to
f9d0acf
Compare
Shekharrajak
approved these changes
Aug 1, 2018
| template_code_str << "\n module View" | ||
| template_code_str << "\n module Adapter" | ||
| template_code_str << "\n module #{file_name.capitalize}Adapter" | ||
| template_code_str << "\n extend self # rubocop:disable Style/ModuleFunction" |
There was a problem hiding this comment.
I still prefer \t than spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to create a rake task to add a new adapter template.
Example:
will create a new file
charts.rbwith all the necessary methods to add an adapter like init, init_script, init_ruby, show_in_iruby and export_html_file as TODO.