-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nim2 update #3
base: master
Are you sure you want to change the base?
Nim2 update #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking more closely, the upstream C bindings should not be overloaded with destructors, those should be added to the Int
type here.
See rationale in subsetpark/nim-gmp#2
I agree with you. Adding destructor to |
da7f11b
to
244356b
Compare
I'll have to get back to this later. Here's my progress - there are very few changes. It's probably 99% done - not sure why it's segfaulting and don't have time to dig into it at the moment. I cheated and used a template to bypass modifying any dereferencing code yet, but would be happy to remove it and roll it out across the code later once everything is working. |
244356b
to
5233c16
Compare
Okay, that was... educational about the defunct finalizers.
|
I'm updating some old code using this.
Changes:
finalizer
mechanics with Nim 2 destructors.Blocking:
Awaiting merging upstream Nim 2 update PR adding destructors to the gmp libraryMerged! :)