Set to disabled as default (ie opt-in to TruncatedStacktraces, instead of opt-out) #24

sjdaines · 2023-03-22T15:14:09Z

Change default setting of disabled option to true, so package is disabled by default and requires a setting in LocalPreferences.toml to enable.

See #22, #23 enabling TruncatedStacktraces can cause significant slowdowns (minutes) in startup, and the LocalPreferences.toml mechanism to disable is not as straightforward as just adding the setting.

Change default setting of disabled option to true, so package is disabled by default and requires a setting in LocalPreferences.toml to enable. See #22, #23 enabling TruncatedStacktraces can cause significant slowdowns (minutes) in startup.

Now that disable = true is the default, need to explicitly enable before running tests

codecov · 2023-03-22T19:12:56Z

Codecov Report

Merging #24 (50d0ab2) into master (6b860aa) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   46.66%   46.66%           
=======================================
  Files           1        1           
  Lines          15       15           
=======================================
  Hits            7        7           
  Misses          8        8

Impacted Files	Coverage Δ
src/TruncatedStacktraces.jl	`46.66% <ø> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sjdaines and others added 3 commits March 22, 2023 15:07

Set disabled by default

15e15df

Change default setting of disabled option to true, so package is disabled by default and requires a setting in LocalPreferences.toml to enable. See #22, #23 enabling TruncatedStacktraces can cause significant slowdowns (minutes) in startup.

Merge branch 'master' into opt_in

1668b8d

Fix tests

90256ce

Now that disable = true is the default, need to explicitly enable before running tests

Update TruncatedStacktraces.jl

50d0ab2

ChrisRackauckas merged commit eb05297 into SciML:master Mar 23, 2023

sjdaines deleted the opt_in branch March 23, 2023 15:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set to disabled as default (ie opt-in to TruncatedStacktraces, instead of opt-out) #24

Set to disabled as default (ie opt-in to TruncatedStacktraces, instead of opt-out) #24

sjdaines commented Mar 22, 2023

codecov bot commented Mar 22, 2023 •

edited

Loading

Set to disabled as default (ie opt-in to TruncatedStacktraces, instead of opt-out) #24

Set to disabled as default (ie opt-in to TruncatedStacktraces, instead of opt-out) #24

Conversation

sjdaines commented Mar 22, 2023

codecov bot commented Mar 22, 2023 • edited Loading

Codecov Report

codecov bot commented Mar 22, 2023 •

edited

Loading