Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forward and inverse application in FFTW tutorial #229

Merged
merged 6 commits into from
Dec 12, 2023

Conversation

ErikQQY
Copy link
Member

@ErikQQY ErikQQY commented Dec 11, 2023

Fix: #228

Checklist

  • Documentation fix

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a389e25) 68.33% compared to head (b03b0be) 13.92%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #229       +/-   ##
===========================================
- Coverage   68.33%   13.92%   -54.41%     
===========================================
  Files          10       10               
  Lines        1642     1637        -5     
===========================================
- Hits         1122      228      -894     
- Misses        520     1409      +889     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

Can you turn this into an @example so it tests the runs?

@ChrisRackauckas
Copy link
Member

Needs to update docs project.toml

@vpuri3
Copy link
Member

vpuri3 commented Dec 12, 2023

rerunning CI

@vpuri3 vpuri3 closed this Dec 12, 2023
@vpuri3 vpuri3 reopened this Dec 12, 2023
@ErikQQY
Copy link
Member Author

ErikQQY commented Dec 12, 2023

Documentation CI is fine, the other CI failed since #226

@ChrisRackauckas ChrisRackauckas merged commit aedb6ad into SciML:master Dec 12, 2023
7 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runnable example doesn't run: wrapping FFT
3 participants