-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Bio for Catalyst v14 and MTK v9 #1022
Conversation
I’d imagine many of these need updating for Catalyst 14 (eg ReactionNetworkImorters generated systems need to be marked complete). |
@isaacsas can you help with what needs to be changed with this bump? |
@ChrisRackauckas LMK if this doesn't work. I think all that was needed was to complete the converted ODESystem, and get the On a sidenote, it would be useful if the parameter to MTKParameter conversion functionality could be factored into an exported user-accessible function so users can manually process parameter maps to the new form. (Essentially a |
Interesting point. Open an issue. |
How long is this benchmark? It seems to error https://buildkite.com/julialang/scimlbenchmarks-dot-jl/builds/2705#019146bf-645a-4b43-b1db-597856afaf3b/403-614 but is holding up the CI for more than a day 😓 |
Maybe @TorkelE knows how long it should take. It is a long one but I have no idea if it should be days. |
Well it's done now. Looks like it takes 60 hours. |
60 hours doesn't seem too outlandish for the BCR one. |
Has the BCR sparse Jacobian compiliation gotten worse? 80 minutes now seems pretty bad and worse than I remember. Also @ChrisRackauckas seems like there are Symbolics related errors in the WP plotting now? |
I don't think it's symbolic, but yes I need to investigate what happened there. |
1997def
to
2fc5137
Compare
@ChrisRackauckas is this good to merge now? @vyudu has another PR to add a new benchmark but we should wait on that one till the updated Project.toml and Manifest.toml are merged. |
This still has a few failures IIUC from the CI |
2fc5137
to
0f296e1
Compare
2841f2e
to
e1a5758
Compare
Okay I'm going to merge and just fix Bikhori separately since that requires a lot less compute. |
No description provided.