Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix several downstream test failures #706

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal AayushSabharwal marked this pull request as draft June 7, 2024 06:48
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 20 lines in your changes missing coverage. Please review.

Project coverage is 41.39%. Comparing base (6b220f9) to head (5112e27).

Files Patch % Lines
ext/SciMLBaseZygoteExt.jl 33.33% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
+ Coverage   31.47%   41.39%   +9.92%     
==========================================
  Files          55       55              
  Lines        4588     4626      +38     
==========================================
+ Hits         1444     1915     +471     
+ Misses       3144     2711     -433     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AayushSabharwal AayushSabharwal changed the title test: several modelingtoolkit-remake test fixes test: fix several downstream test failures Jun 7, 2024
@AayushSabharwal AayushSabharwal marked this pull request as ready for review June 7, 2024 10:12
@ChrisRackauckas ChrisRackauckas merged commit ff83ff0 into SciML:master Jun 7, 2024
30 of 42 checks passed
@AayushSabharwal AayushSabharwal deleted the as/hotfix-hotfix branch June 7, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants