refactor: move type-pirated function from BoundaryValueDiffEq here, use Accessors.jl #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #696 +/- ##
===========================================
- Coverage 41.53% 30.82% -10.71%
===========================================
Files 55 55
Lines 4582 4577 -5
===========================================
- Hits 1903 1411 -492
- Misses 2679 3166 +487 ☔ View full report in Codecov by Sentry. |
AayushSabharwal
force-pushed
the
as/bv-diffeq-internals
branch
from
249e69f
to
6f91b3f
Compare
|
Fix conflict? |
AayushSabharwal
force-pushed
the
as/bv-diffeq-internals
branch
3 times, most recently
from
908c197
to
d74e879
Compare
|
I'm looking into what is cancelling these tests |
test/downstream/symbol_indexing.jl
Outdated
| @test getp(sys, b)(sol) ≈ 100 | ||
| @test sol.ps[a] ≈ 1 | ||
| @test sol.ps[b] ≈ 100 | ||
| sol = @test_throws ArgumentError solve(prob, GradientDescent()) |
There was a problem hiding this comment.
ERROR: ArgumentError: Fminbox(GradientDescent{LineSearches.InitialPrevious{Float64}, LineSearches.HagerZhang{Float64, Base.RefValue{Bool}}, Nothing, Optim.var"#13#15"}(LineSearches.InitialPrevious{Float64}
alpha: Float64 1.0
alphamin: Float64 0.0
alphamax: Float64 Inf
, LineSearches.HagerZhang{Float64, Base.RefValue{Bool}}
delta: Float64 0.1
sigma: Float64 0.9
alphamax: Float64 Inf
rho: Float64 5.0
epsilon: Float64 1.0e-6
gamma: Float64 0.66
linesearchmax: Int64 50
psi3: Float64 0.1
display: Int64 0
mayterminate: Base.RefValue{Bool}
, nothing, Optim.var"#13#15"(), Flat())) requires gradients, since you didn't use `OptimizationFunction` with a valid AD backend https://docs.sciml.ai/Optimization/stable/API/ad/ the lower and upper bounds thus will be ignored.
I had messaged Vaibhav about it when it came up, not sure if he has been able to fix it yet.
There was a problem hiding this comment.
It was fixed I have created a release for it now
|
Requires SciML/RecursiveArrayTools.jl#384 |
AayushSabharwal
force-pushed
the
as/bv-diffeq-internals
branch
from
821f586
to
317adb1
Compare
This avoids loading `ADTypes.jl` before downstream tests are precompiled
AayushSabharwal
force-pushed
the
as/bv-diffeq-internals
branch
from
317adb1
to
55d81af
Compare
ChrisRackauckas
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.