Re-enable GC of RGFs which haven't been drop_expr()d
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YingboMa
approved these changes
May 30, 2023
YingboMa
reviewed
May 30, 2023
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 94.00% 89.62% -4.38%
==========================================
Files 1 1
Lines 100 106 +6
==========================================
+ Hits 94 95 +1
- Misses 6 11 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
devmotion
reviewed
May 30, 2023
|
Ok I think I cleaned those things up now. Should be good to go :) |
YingboMa
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert some of #62
Originally GC of RGFs was implemented because people seemed to need it. So dropping support for this completely doesn't seem great.
Instead, this PR lets normal RGF bodies be GC'd as always. But if one calls
drop_expr, we upgrade theWeakRefto a normal strong reference in the cache, preventing the body from being GC'd thereafter.