support for closures via opaque closures #32
Conversation
Should close SciML#28. Kwargs or `where` parameters might not work, but that's an issue in Julia base.
| @@ -44,9 +51,13 @@ end | |||
| """ | |||
| struct RuntimeGeneratedFunction{argnames, cache_tag, context_tag, id} <: Function | |||
| body::Expr | |||
| function RuntimeGeneratedFunction(cache_tag, context_tag, ex) | |||
| function RuntimeGeneratedFunction(cache_tag, context_tag, ex; opaque_closures=true) | |||
There was a problem hiding this comment.
doesn't this need to be set based on the Julia version?
There was a problem hiding this comment.
See the check just below. It's ignored if Base.Experimental.@opaque is not defined.
|
Somehow the timing regression tests are failing now? |
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
+ Coverage 93.33% 97.67% +4.34%
==========================================
Files 1 1
Lines 45 86 +41
==========================================
+ Hits 42 84 +42
+ Misses 3 2 -1
Continue to review full report at Codecov.
|
|
Ah, I just forgot to add the keyword to the other method as well. |
|
Great thanks! |
|
Thanks! |
|
Thanks! This looks great! We needed this pretty badly. |
|
Nice! So great that the compiler can now do most of the work for us here :) |
Should close #28. Kwargs or
whereparameters might not work, but that's an issue in Julia base.