Adapt KrylovSubspace Vtype to u #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcarmesin
changed the title
|
This should get a GPU test, but I'll take it for now. If you follow up with a GPU test I'd be super happy though. |
|
Actually, it looks like we'd need https://github.com/SciML/OrdinaryDiffEq.jl/pull/2538/files#diff-607a9c510d9924b2cd586818d852d3fe0f67a0d58a58bf2c6c9e4fcb6bb5518fR576 that line as well for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Specify the type of the
KrylovSubspacebasis vector matrix according to the specifiedu. This allows forubeing a GPUArray.ExponentiationUtilities has to be adjusted as well to provide this functionality, see my PR https://github.com/SciML/ExponentialUtilities.jl/pull/183 there.