-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Aliasing API #2503
Use Aliasing API #2503
Conversation
62b60f1
to
d05bb41
Compare
0d07625
to
bdaa141
Compare
This just needs to use to use the version of SciMLBase with the AliasSpecifiers once that's released, then it should work and pass tests. |
lib/OrdinaryDiffEqCore/src/solve.jl
Outdated
# If alias isa Bool, all fields of ODEAliases set to alias | ||
if alias isa Bool | ||
aliases = ODEAliasSpecifier(alias = alias) | ||
elseif isnothing(alias) || alias isa ODEAliasSpecifier | ||
aliases = alias | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Canonicalize this in the DifEqBase part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean. This is here so that if alias = true
or alias = false
in solve
that gets passed to the ODEAliasSpecifier
constructor so that every variable is aliased / not aliased.
Oh yeah, this will require a release of DiffEqBase so that the |
@ChrisRackauckas any chance of a new SciMLBase release coming soon? Also, I documented the |
Done.
Yes in the DiffEqBase/solve.jl docstring. |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This makes use of the Aliasing API in SciMLBase SciML/SciMLBase.jl#830
The default of
alias_u0
is preserved here, and it isn't breaking because it still respects whenalias_u0
is put in as a kwarg to solve.