Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Differentiation Interface #2482

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oscardssmith
Copy link
Contributor

Very WIP, but this starts us on the move to DifferentiationInterface. Remaining TODO items:

  • FunctionWrapper support
  • resizing
  • "AutoBackend" (that uses the jac/tgrad/sparsity info as appropriate)

@gdalle
Copy link

gdalle commented Sep 30, 2024

Awesome work! Happy to help further.
Here's a little reading list:

@@ -117,7 +120,7 @@ Update the Jacobian object `J`.

If `integrator.f` has a custom Jacobian update function, then it will be called. Otherwise,
either automatic or finite differencing will be used depending on the `cache`.
If `next_step`, then it will evaluate the Jacobian at the next step.
If `next_step`, theOrdinaryDiffEqRosenbrock/src/rosenbrock_perform_step.jl:n it will evaluate the Jacobian at the next step.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a mistake! 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants