Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin Rosenbrock refactor #2430

Merged
merged 61 commits into from
Sep 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
e6c5dcb
commit
ParamThakkar123 Aug 22, 2024
5aa94f9
Cleaned master
ParamThakkar123 Aug 22, 2024
a315d61
Merge branch 'master' of https://github.com/SciML/OrdinaryDiffEq.jl
ParamThakkar123 Aug 22, 2024
c6f7351
Merge branch 'master' of https://github.com/SciML/OrdinaryDiffEq.jl
ParamThakkar123 Aug 25, 2024
36487a2
Perform step refactor for rosenbrock
ParamThakkar123 Aug 25, 2024
cd77267
Rodas4Cache to RosenbrockCache
ParamThakkar123 Aug 25, 2024
aeb1520
Type error fix
ParamThakkar123 Aug 25, 2024
0512ead
Small mistake fix
ParamThakkar123 Aug 25, 2024
e2a55a7
Fixes
ParamThakkar123 Aug 25, 2024
a2dde84
fixes
ParamThakkar123 Aug 25, 2024
4c60b7a
Fixes
ParamThakkar123 Aug 25, 2024
3ef42bd
reappply
ParamThakkar123 Aug 25, 2024
5eb818a
du1 fix
ParamThakkar123 Aug 25, 2024
adacbc5
du1 fix
ParamThakkar123 Aug 25, 2024
3f73a47
Fixes
ParamThakkar123 Aug 25, 2024
2732290
Fixes
ParamThakkar123 Aug 25, 2024
5c2be82
Fixes
ParamThakkar123 Aug 25, 2024
c28f37b
fixes
oscardssmith Aug 25, 2024
594b77d
Fixes
ParamThakkar123 Aug 26, 2024
8014a9d
Fixes
ParamThakkar123 Aug 26, 2024
183b83a
Fixes
ParamThakkar123 Aug 26, 2024
94659b1
Fixes
ParamThakkar123 Aug 26, 2024
91597e7
Fixes
ParamThakkar123 Aug 26, 2024
357c76e
Fixes
ParamThakkar123 Aug 26, 2024
a6bbc50
simplifications
oscardssmith Aug 26, 2024
b396746
fix tableaus
oscardssmith Aug 26, 2024
ebc2fca
simplifications
oscardssmith Aug 26, 2024
bc53a6d
in place works
oscardssmith Aug 26, 2024
d97102e
non-identity mass_matrix oop fix
oscardssmith Aug 26, 2024
f407b73
fix addsteps
oscardssmith Aug 26, 2024
0df6173
bugfixes
oscardssmith Aug 27, 2024
af5e51b
fix addsteps
oscardssmith Aug 27, 2024
f6ade39
fixes
oscardssmith Aug 27, 2024
18897d5
opts
ParamThakkar123 Aug 27, 2024
9456e80
fixes
oscardssmith Aug 27, 2024
9beaf13
undo param change
oscardssmith Aug 27, 2024
c980a73
fixes
ParamThakkar123 Aug 27, 2024
5ca7aa1
Merge branch 'Fixes6' of https://github.com/ParamThakkar123/OrdinaryD…
ParamThakkar123 Aug 27, 2024
8748ceb
Fixes
ParamThakkar123 Aug 27, 2024
50c8eed
revert
ParamThakkar123 Aug 27, 2024
ac27761
Fixes
ParamThakkar123 Aug 27, 2024
f1ba405
Fixes
ParamThakkar123 Aug 27, 2024
ae1a7f9
Fixes
ParamThakkar123 Aug 27, 2024
f67add8
partial fix addsteps!
oscardssmith Aug 28, 2024
85e5d2e
inplace addsteps
oscardssmith Aug 28, 2024
325cef9
fixed convergance
oscardssmith Aug 28, 2024
d7930c8
fix inplace and tableau format
oscardssmith Aug 29, 2024
6cb8122
fix resize
oscardssmith Aug 29, 2024
2d72836
fix tableaus
oscardssmith Aug 29, 2024
d477d7d
make k generic
oscardssmith Aug 29, 2024
6add4d6
Fixes
ParamThakkar123 Aug 29, 2024
5439e58
Merge branch 'Fixes6' of https://github.com/ParamThakkar123/OrdinaryD…
ParamThakkar123 Aug 29, 2024
e94e560
fixes
ParamThakkar123 Aug 29, 2024
24a12c0
move ks to constcache
oscardssmith Aug 29, 2024
9342c37
du
ParamThakkar123 Aug 30, 2024
90df7ef
Fix
ParamThakkar123 Aug 30, 2024
0a99a8f
Some more fixes
ParamThakkar123 Aug 30, 2024
d76108c
revert incorrect fixes
oscardssmith Aug 30, 2024
e05ccf8
fix oop addsteps
oscardssmith Aug 30, 2024
2368679
make oop mutation free
oscardssmith Sep 1, 2024
bd9ec06
typos
oscardssmith Sep 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqDifferentiation/src/alg_utils.jl
Original file line number Diff line number Diff line change
Expand Up @@ -76,4 +76,4 @@ end
@generated function pick_static_chunksize(::Val{chunksize}) where {chunksize}
x = ForwardDiff.pickchunksize(chunksize)
:(Val{$x}())
end
end
48 changes: 24 additions & 24 deletions lib/OrdinaryDiffEqDifferentiation/src/derivative_utils.jl
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ struct StaticWOperator{isinv, T, F} <: AbstractSciMLOperator{T}
# doing to how StaticArrays and StaticArraysCore are split up
StaticArrays.LU(LowerTriangular(W), UpperTriangular(W), SVector{n}(1:n))
else
lu(W, check = false)
lu(W, check=false)
end
# when constructing W for the first time for the type
# inv(W) can be singular
Expand Down Expand Up @@ -932,28 +932,28 @@ function LinearSolve.init_cacheval(
end

for alg in [LinearSolve.AppleAccelerateLUFactorization,
LinearSolve.BunchKaufmanFactorization,
LinearSolve.CHOLMODFactorization,
LinearSolve.CholeskyFactorization,
LinearSolve.CudaOffloadFactorization,
LinearSolve.DiagonalFactorization,
LinearSolve.FastLUFactorization,
LinearSolve.FastQRFactorization,
LinearSolve.GenericFactorization,
LinearSolve.GenericLUFactorization,
LinearSolve.KLUFactorization,
LinearSolve.LDLtFactorization,
LinearSolve.LUFactorization,
LinearSolve.MKLLUFactorization,
LinearSolve.MetalLUFactorization,
LinearSolve.NormalBunchKaufmanFactorization,
LinearSolve.NormalCholeskyFactorization,
LinearSolve.QRFactorization,
LinearSolve.RFLUFactorization,
LinearSolve.SVDFactorization,
LinearSolve.SimpleLUFactorization,
LinearSolve.SparspakFactorization,
LinearSolve.UMFPACKFactorization]
LinearSolve.BunchKaufmanFactorization,
LinearSolve.CHOLMODFactorization,
LinearSolve.CholeskyFactorization,
LinearSolve.CudaOffloadFactorization,
LinearSolve.DiagonalFactorization,
LinearSolve.FastLUFactorization,
LinearSolve.FastQRFactorization,
LinearSolve.GenericFactorization,
LinearSolve.GenericLUFactorization,
LinearSolve.KLUFactorization,
LinearSolve.LDLtFactorization,
LinearSolve.LUFactorization,
LinearSolve.MKLLUFactorization,
LinearSolve.MetalLUFactorization,
LinearSolve.NormalBunchKaufmanFactorization,
LinearSolve.NormalCholeskyFactorization,
LinearSolve.QRFactorization,
LinearSolve.RFLUFactorization,
LinearSolve.SVDFactorization,
LinearSolve.SimpleLUFactorization,
LinearSolve.SparspakFactorization,
LinearSolve.UMFPACKFactorization]
@eval function LinearSolve.init_cacheval(alg::$alg, A::WOperator, b, u, Pl, Pr,
maxiters::Int, abstol, reltol, verbose::Bool,
assumptions::OperatorAssumptions)
Expand Down Expand Up @@ -997,4 +997,4 @@ function resize_J_W!(cache, integrator, i)
end

nothing
end
end
2 changes: 1 addition & 1 deletion lib/OrdinaryDiffEqRosenbrock/src/interp_func.jl
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ function DiffEqBase.interp_summary(::Type{cacheType},
dense::Bool) where {
cacheType <:
Union{Rodas4ConstantCache, Rodas23WConstantCache, Rodas3PConstantCache,
Rodas4Cache, Rodas23WCache, Rodas3PCache}}
RosenbrockCache, Rodas23WCache, Rodas3PCache}}
dense ? "specialized 3rd order \"free\" stiffness-aware interpolation" :
"1st order linear"
end
Expand Down
Loading
Loading