Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finalize callbacks. #2061

Merged
merged 4 commits into from
Nov 18, 2023
Merged

finalize callbacks. #2061

merged 4 commits into from
Nov 18, 2023

Conversation

oscardssmith
Copy link
Contributor

fixes SciML/DiffEqBase.jl#931 (although we probably need a similar line added for Sundials.jl)

fixes SciML/DiffEqBase.jl#931 (although we probably need a similar line added for `Sundials.jl`)
@ChrisRackauckas
Copy link
Member

Yes Sundials and StochasticDiffEq

oscardssmith added a commit to oscardssmith/Sundials.jl that referenced this pull request Nov 15, 2023
oscardssmith added a commit to oscardssmith/StochasticDiffEq.jl that referenced this pull request Nov 15, 2023
@oscardssmith oscardssmith reopened this Nov 17, 2023
@ChrisRackauckas ChrisRackauckas merged commit da70b26 into SciML:master Nov 18, 2023
102 of 112 checks passed
ChrisRackauckas pushed a commit to SciML/Sundials.jl that referenced this pull request Nov 18, 2023
@staticfloat
Copy link
Contributor

Does this also close #1941 ?

@ChrisRackauckas
Copy link
Member

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DiscreteCallback finalize not getting called at end of solve().
3 participants