Some methods are in the wrong sub-package

[ranocha]

1. SHLDDRK_2N and SHLDDRK52 should be moved from OrdinaryDiffEqSSPRK.jl to OrdinaryDiffEqLowStorageRK.jl since they are not SSP
2. KYK2014DGSSPRK_3S2 should be moved from OrdinaryDiffEqLowStorageRK.jl to OrdinaryDiffEqSSPRK.jl since the other SSP methods are there, even if they are low storage (which most of them are)
3. The docstring of ssp_coefficient should move from OrdinaryDiffEqLowStorageRK.jl to OrdinaryDiffEqSSPRK.jl or OrdinaryDiffEqCore.jl

Details

OrdinaryDiffEq.jl/lib/OrdinaryDiffEqSSPRK/src/OrdinaryDiffEqSSPRK.jl

Line 102 in dc0e1e7

SSPRK33, SHLDDRK_2N, KYKSSPRK42, SHLDDRK52

SHLDDRK_2N and SHLDDRK52 are not SSP methods but low-storage methods. There is also no ssp_coefficient defined for them, see

OrdinaryDiffEq.jl/lib/OrdinaryDiffEqSSPRK/src/alg_utils.jl

Lines 36 to 52 in dc0e1e7

	ssp_coefficient(alg::SSPRK53_2N1) = 2.18
	ssp_coefficient(alg::SSPRK53_2N2) = 2.148
	ssp_coefficient(alg::SSPRK53) = 2.65
	ssp_coefficient(alg::SSPRK53_H) = 2.65
	ssp_coefficient(alg::SSPRK63) = 3.518
	ssp_coefficient(alg::SSPRK73) = 4.2879
	ssp_coefficient(alg::SSPRK83) = 5.107
	ssp_coefficient(alg::SSPRK43) = 2
	ssp_coefficient(alg::SSPRK432) = 2
	ssp_coefficient(alg::SSPRK932) = 6
	ssp_coefficient(alg::SSPRK54) = 1.508
	ssp_coefficient(alg::SSPRK104) = 6
	ssp_coefficient(alg::SSPRK33) = 1
	ssp_coefficient(alg::SSPRK22) = 1
	ssp_coefficient(alg::SSPRKMSVS32) = 0.5
	ssp_coefficient(alg::SSPRKMSVS43) = 0.33
	ssp_coefficient(alg::KYKSSPRK42) = 2.459

OrdinaryDiffEq.jl/lib/OrdinaryDiffEqLowStorageRK/src/OrdinaryDiffEqLowStorageRK.jl

Line 107 in dc0e1e7

KYK2014DGSSPRK_3S2, RK46NL

KYK2014DGSSPRK_3S2 is an SSP method, see also

OrdinaryDiffEq.jl/lib/OrdinaryDiffEqLowStorageRK/src/alg_utils.jl

Lines 86 to 100 in dc0e1e7

	"""
	ssp_coefficient(alg)
	Return the SSP coefficient of the ODE algorithm `alg`. If one time step of size
	`dt` with `alg` can be written as a convex combination of explicit Euler steps
	with step sizes `cᵢ * dt`, the SSP coefficient is the minimal value of `1/cᵢ`.
	# Examples
	```julia-repl
	julia> ssp_coefficient(SSPRK104())
	6
	```
	"""
	ssp_coefficient(alg::KYK2014DGSSPRK_3S2) = 0.8417

[ChrisRackauckas]

@ParamThakkar123 can you take a look at this?

[ParamThakkar123]

Yes I will take this. I will make the change

[ranocha]

Thanks!

[ParamThakkar123]

@ranocha the fix has been incorporated in my recent PR #2320

[oscardssmith]

IMO it relaly should be a separate PR to make review easier (especially because I expect this change to merge sooner).

[ChrisRackauckas]

Did these fixes get a separate PR?

[ParamThakkar123]

Did these fixes get a separate PR?

Actually I first did this in the same PR #2320. But then on @oscardssmith suggestion, I reverted it and will start a new one soon.

[ParamThakkar123]

@ranocha should the cache also be modified like in SHLDDRK_2N uses SSPRKMutableCache

like here :

[ChrisRackauckas]

yes fix the abstract types.

[ParamThakkar123]

yes fix the abstract types.

Should I replace SSPRKMutableCache directly to LowStorageRKCache ?? Or there would be some other changes to make

[ChrisRackauckas]

Both subpackages have an abstract type for the caches of their group. Just apply the one for the destination.