Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide as_expression=false option to ODEs/SDEs, for specific use cases that need to avoid world age issues (generally not needed) #477

Merged
merged 2 commits into from
Jun 24, 2020

Conversation

dpad
Copy link
Contributor

@dpad dpad commented Jun 23, 2020

New option that restores the GeneralizedGenerated functions in ODEFunction, for some very specific use cases:

  • Building an ODEFunction during precompilation (albeit still with long "evaluating into a closed module/incremental compilation may be fatally broken" warnings).
  • Building an ODEFunction and calling it from within the same non-global scope.

…c use cases that need to avoid world age issues arising from evaluating expressions.
@ChrisRackauckas
Copy link
Member

IMO, this should be applied uniformly, i.e. ODEProblem, SDEProblem/Function, Nonlinear, Optimization

@dpad
Copy link
Contributor Author

dpad commented Jun 24, 2020

I've added ODEProblem, SDEProblem, and SDEFunction. However, Nonlinear and Optimization seem to already be split according to expression=Val{false} and expression=Val{true} for the Expr version, so I wasn't too sure what I should change there.

@dpad dpad changed the title Provide as_expression=false option in ODEFunction, for specific use cases that need to avoid world age issues (not needed by default!) Provide as_expression=false option to ODEs/SDEs, for specific use cases that need to avoid world age issues (not needed by default!) Jun 24, 2020
@dpad dpad changed the title Provide as_expression=false option to ODEs/SDEs, for specific use cases that need to avoid world age issues (not needed by default!) Provide as_expression=false option to ODEs/SDEs, for specific use cases that need to avoid world age issues (generally not needed) Jun 24, 2020
@ChrisRackauckas ChrisRackauckas merged commit 388eb29 into SciML:master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants