test: make initializaton tests runnable from OrdinaryDiffEq #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/runtests.jl
Outdated
| @@ -33,7 +33,6 @@ end | |||
| @safetestset "Dynamic Quantities Test" include("dq_units.jl") | |||
| @safetestset "Unitful Quantities Test" include("units.jl") | |||
| @safetestset "Mass Matrix Test" include("mass_matrix.jl") | |||
| @safetestset "InitializationSystem Test" include("initializationsystem.jl") | |||
| @safetestset "Guess Propagation" include("guess_propagation.jl") | |||
| @safetestset "Hierarchical Initialization Equations" include("hierarchical_initialization_eqs.jl") | |||
There was a problem hiding this comment.
Also initial Values test?
There was a problem hiding this comment.
All three of those are purely MTK functionalities, though? Why would OrdinaryDiffEq need to test them?
There was a problem hiding this comment.
They are initialization tests
This was referenced Nov 26, 2024
AayushSabharwal
force-pushed
the
as/initialization-testset
branch
from
936ba39 to
861e7ae
Compare
test/runtests.jl
Outdated
| @safetestset "Equation Type Accessors Test" include("equation_type_accessors.jl") | ||
| @safetestset "Equations with complex values" include("complex.jl") | ||
| end | ||
| end | ||
|
|
||
| if GROUP == "All" || GROUP == "InterfaceI" || GROUP == "Initialization" |
There was a problem hiding this comment.
Suggested change
| if GROUP == "All" || GROUP == "InterfaceI" || GROUP == "Initialization" | |
| if GROUP == "All" || GROUP == "Initialization" |
And just make a new test group in the Github CI. We keep putting everything into InterfaceI so fully splitting is good!
AayushSabharwal
force-pushed
the
as/initialization-testset
branch
from
861e7ae to
d73342d
Compare
ChrisRackauckas
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OrdinaryDiffEq otherwise does not test
OverrideInitChecklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.