Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize UMFPack initialization #74

Merged
merged 1 commit into from
Dec 19, 2021
Merged

Specialize UMFPack initialization #74

merged 1 commit into from
Dec 19, 2021

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

@ChrisRackauckas
Copy link
Member Author

@Wimmerer could you look into the KLU one? This one might finally finish the SciML/OrdinaryDiffEq.jl#1543 PR.

@rayegun
Copy link
Collaborator

rayegun commented Dec 19, 2021

Yes, but why are we constructing the UMFPACK factorization directly? So that we don't immediately run the symbolic?

@ChrisRackauckas
Copy link
Member Author

Yes, we just want the initialization of the cache without doing any of the work in order to get the types right.

@rayegun rayegun mentioned this pull request Dec 19, 2021
@codecov
Copy link

codecov bot commented Dec 19, 2021

Codecov Report

Merging #74 (0ffb9eb) into main (d443210) will decrease coverage by 0.78%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   79.24%   78.45%   -0.79%     
==========================================
  Files           7        7              
  Lines         371      376       +5     
==========================================
+ Hits          294      295       +1     
- Misses         77       81       +4     
Impacted Files Coverage Δ
src/factorization.jl 80.64% <100.00%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d443210...0ffb9eb. Read the comment docs.

@rayegun
Copy link
Collaborator

rayegun commented Dec 19, 2021

I'll also see if I can make a PR to SuiteSparse.jl, it seems really bad that we should be handling finalizers at this level just to defer factorization.

@ChrisRackauckas ChrisRackauckas merged commit fea4fbb into main Dec 19, 2021
@ChrisRackauckas ChrisRackauckas deleted the umfpack branch December 19, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants