Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MinAres solver to iterative wrappers #558

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

mertkipcak
Copy link
Contributor

@mertkipcak mertkipcak commented Nov 13, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

A very minor change to add the minares solver from Krylov.jl to the iterative wrappers. The paper can be found here

@ChrisRackauckas
Copy link
Member

UndefVarError: KrylovJL_MINARES not defined

Export is missing.

test/basictests.jl Outdated Show resolved Hide resolved
@mertkipcak
Copy link
Contributor Author

Hi Chris, thanks for fix on the typo and the export! Please let me know if I need to update anything else

@ChrisRackauckas ChrisRackauckas merged commit a183391 into SciML:main Nov 14, 2024
8 of 27 checks passed
@ChrisRackauckas
Copy link
Member

No problem. Works on LTS, v1 tests are just an Enzyme thing, so this is good to go.

@mertkipcak
Copy link
Contributor Author

@ChrisRackauckas, quick question. What is usually the release schedule? If it is not close by, I'll just use my fork for now

@ChrisRackauckas
Copy link
Member

done

@mertkipcak
Copy link
Contributor Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants