Don't default to MKL on EPYC #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselrod
reviewed
Jul 28, 2024
Co-authored-by: Chris Elrod <[email protected]>
ChrisRackauckas
commented
Jul 29, 2024
ChrisRackauckas
commented
Jul 29, 2024
ChrisRackauckas
commented
Jul 29, 2024
ChrisRackauckas
commented
Jul 29, 2024
test/static_arrays.jl
Outdated
| @@ -17,7 +17,7 @@ for alg in (nothing, LUFactorization(), SVDFactorization(), CholeskyFactorizatio | |||
| sol = solve(LinearProblem(A, b), alg) | |||
| @inferred solve(LinearProblem(A, b), alg) | |||
| @test norm(A * sol .- b) < 1e-10 | |||
| if alg <: KrylovJL_GMRES | |||
There was a problem hiding this comment.
Suggested change
| if alg <: KrylovJL_GMRES | |
| if alg isa KrylovJL_GMRES |
There was a problem hiding this comment.
That's what I had first 26574e6
There was a problem hiding this comment.
If a isa T is like typeof(a) <: T, but the former is preferred.
If a isn't a type, a <: T doesn't make sense and will throw an error.
https://github.com/SciML/LinearSolve.jl/actions/runs/10153821474/job/28077889265?pr=518#step:6:1114
ChrisRackauckas
commented
Jul 30, 2024
chriselrod
reviewed
Jul 30, 2024
test/static_arrays.jl
Outdated
|
|
||
| if __non_native_static_array_alg(alg) | ||
| @test_broken __solve_no_alloc(A, b, alg) | ||
| if alg isa Function && alg === KrylovJL_GMRES |
There was a problem hiding this comment.
Suggested change
| if alg isa Function && alg === KrylovJL_GMRES | |
| if alg isa KrylovJL |
I tested in the REPL:
julia> using LinearSolve
julia> alg = KrylovJL_GMRES()
KrylovJL{typeof(Krylov.gmres!), Int64, Tuple{}, Base.Pairs{Symbol, Union{}, Tuple{}, @NamedTuple{}}}(Krylov.gmres!, 0, 0, (), Base.Pairs{Symbol, Union{}, Tuple{}, @NamedTuple{}}())
julia> alg isa KrylovJL
true
chriselrod
reviewed
Jul 30, 2024
Co-authored-by: Chris Elrod <[email protected]>
oscardssmith
pushed a commit
to oscardssmith/LinearSolve.jl
that referenced
this pull request
Aug 5, 2024
* Don't default to MKL on EPYC * import correctly * Update Project.toml * Update Project.toml Co-authored-by: Chris Elrod <[email protected]> * Update qa.jl * Update static_arrays.jl * Update test/static_arrays.jl * Update test/static_arrays.jl * Update adjoint.jl * Update test/adjoint.jl * Update static_arrays.jl * Update static_arrays.jl * Update test/static_arrays.jl * Update static_arrays.jl * Update test/static_arrays.jl * Update test/static_arrays.jl Co-authored-by: Chris Elrod <[email protected]> --------- Co-authored-by: Chris Elrod <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.