Setup Accelerate and MKL for 32-bit, MKL getrf, and Metal.jl integration #361
+375
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ai-maintainer[bot]](https://avatars.githubusercontent.com/in/339956?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for your contribution!
This pull request is too large for automated review.Reviewed with AI Maintainer
Codecov Report
@@ Coverage Diff @@
## main #361 +/- ##
==========================================
- Coverage 73.83% 69.95% -3.88%
==========================================
Files 19 20 +1
Lines 1353 1428 +75
==========================================
Hits 999 999
- Misses 354 429 +75
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Tried to run the Metal benchmark and I'm getting this error:
|
|
You need to re-instantiate for it to bring in the extension from a PR branch. |
|
Why do we need MKL 32-bit? |
Co-authored-by: Christian Guinard <[email protected]>
|
GPU comparison, Neural ODE training, mixed precision algorithms, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of a lot in a single PR but this is what I ended up with after a flight