-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backtracking line search #2
Open
Xiaoyi-Qu
wants to merge
9
commits into
SciML:main
Choose a base branch
from
Xiaoyi-Qu:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2e3b46c
GitKraken trial.
Xiaoyi-Qu fe6150e
Add backtracking line search
Xiaoyi-Qu 293ba58
Modify Backtracking.jl file.
Xiaoyi-Qu 640d515
Add the test and resolve the error.
Xiaoyi-Qu 862185b
Delete my_f function
Xiaoyi-Qu a3dc3e0
Small change
Xiaoyi-Qu fa4ebb2
Delete redundant information
Xiaoyi-Qu b01d7c2
Rewrite the backtracking line search
Xiaoyi-Qu 049902f
Rewrite runtests.jl
Xiaoyi-Qu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,9 @@ uuid = "87fe0de2-c867-4266-b59a-2f0a94fc965b" | |
authors = ["Vaibhav Dixit <[email protected]> and contributors"] | ||
version = "1.0.0-DEV" | ||
|
||
[deps] | ||
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" | ||
|
||
[compat] | ||
julia = "1.9" | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
#= | ||
Backtracking line search implementation | ||
=# | ||
|
||
#= | ||
Input parameters: | ||
- x: current iterate | ||
- g: gradient | ||
- α: initial step size | ||
- p: descent direction | ||
- f: function evaluation | ||
=# | ||
|
||
mutable struct Backtracking{X, F, A} | ||
x::X | ||
g::X | ||
p::X | ||
f::F | ||
α::A | ||
end | ||
|
||
# Determine step size by backtracking line search | ||
function Backtracking(backtrack::Backtracking) | ||
# Setup (Function information) | ||
x = backtrack.x | ||
g = backtrack.g | ||
α = backtrack.α | ||
p = backtrack.p | ||
f = backtrack.f | ||
|
||
# Setup (Parameters) | ||
c1 = 1e-4 | ||
β = 0.5 | ||
iterations = 1_000 | ||
|
||
ϕ_0 = f(x) | ||
ϕ_α = f(x + α*p) | ||
iteration = 0 | ||
|
||
# Backtracking line search | ||
while ϕ_α > ϕ_0 + c1 * α * g * p | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move this oput to a separate function that takes as argument the function and a |
||
# Increment the number of steps we've had to perform | ||
iteration += 1 | ||
|
||
# Ensure termination | ||
if iteration > iterations | ||
throw(LineSearchException("Linesearch failed to converge, reached maximum iterations $(iterations).", α)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't throw an error, return NaN |
||
end | ||
|
||
# Decrease the step-size | ||
α = β * α | ||
|
||
# Update function value at new iterate | ||
ϕ_α = f(x + α*p) | ||
end | ||
|
||
return α | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,8 @@ module LineSearch | |
|
||
# Write your package code here. | ||
|
||
end | ||
include("Backtracking.jl") | ||
|
||
export Backtracking | ||
|
||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this should be a constructor for the method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel confused about this comment. In the function
Backtracking
, there are five arguments includingf
. Heref
is a function. A function cannot be an argument of a function. That is where I feel confused.