New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Expose solve's keyword arguments in datafit #173

Closed

joshday wants to merge 1 commit into SciML:main from joshday:patch-1

joshday commented Jun 8, 2023

I think I'm missing some context as to what Chris is describing in his comment, but I believe this fixes/enables #158.

I'll update the docs if maintainers think this is an agreeable change.


          Update datafit.jl to fix SciML#158

d65aade

Contributor

anandijain commented Jun 9, 2023

https://github.com/SciML/EasyModelAnalysis.jl/pull/172/files#diff-a823f2cccdf50aeada25e1047fd0e077a6500fc86cb107ffd3085ebf9a09a561R49
I did this in here too. I think that PR is good to merge. There was some doc failures, but the tests passed

Author

joshday commented Jun 9, 2023

Ah okay, I missed that! I'll close this then.

joshday closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet