New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix remaining allocations in `PresetTimeCallback` #218

Merged

ChrisRackauckas merged 2 commits into SciML:master from oscardssmith:os/preset-time-allocations-redux

Apr 29, 2024

Contributor

oscardssmith commented Apr 29, 2024 •

edited

Loading

I was missing a let that was causing tstops to be captured by the condition closure. Fixes #217. We now get

julia> @time solve(prob, Tsit5(), callback=callback);
  0.000988 seconds (95 allocations: 44.703 KiB)

where all the additional allocations are in the init stage.


          fix remaining allocations

e8588fe

oscardssmith mentioned this pull request

Memory allocations (Still) of PresetTimeCallback after v3.2.0 #217

Closed


          format

b311715

ChrisRackauckas merged commit afff8e3 into SciML:master

8 of 10 checks passed

oscardssmith deleted the os/preset-time-allocations-redux branch

April 29, 2024 16:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet