Fix code #57
Merged
Fix code #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #57 +/- ##
=======================================
Coverage 85.52% 85.52%
=======================================
Files 14 14
Lines 456 456
=======================================
Hits 390 390
Misses 66 66
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Comment on lines
+2
to
+9
| always_use_return = true | ||
| margin = 92 | ||
| indent = 2 | ||
| format_docstrings = true | ||
| join_lines_based_on_source = true | ||
| separate_kwargs_with_semicolon = true | ||
| always_for_in = true |
There was a problem hiding this comment.
Most are these except the indent one just enforce some "stricter" conventions compared to SciMLStyle. Also gets rid of some conventions which I find weird, especially the return last value without an explicit return statement. Some of them need to be removed (I just copied it over from one of my other repos).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.