Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the codebase and use the latest versions of NonlinearSolve and SteadyStateDiffEq #114

Merged
merged 16 commits into from
Dec 20, 2023

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Dec 18, 2023

Fixes #105, Fixes #94

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (fd1a8ba) 95.65% compared to head (b67f684) 93.85%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/utils.jl 92.20% 6 Missing ⚠️
src/layers.jl 94.68% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   95.65%   93.85%   -1.80%     
==========================================
  Files           9        5       -4     
  Lines         207      179      -28     
==========================================
- Hits          198      168      -30     
- Misses          9       11       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal force-pushed the ap/nlsolve_up branch 3 times, most recently from 461aa79 to 1e76987 Compare December 18, 2023 03:48
@avik-pal avik-pal force-pushed the ap/nlsolve_up branch 5 times, most recently from b0ec823 to 3f18e69 Compare December 18, 2023 12:42
@avik-pal
Copy link
Member Author

avik-pal commented Dec 18, 2023

@ChrisRackauckas can you create a buildkite pipeline for this package? NVM I can create it on buildkite

@avik-pal avik-pal force-pushed the ap/nlsolve_up branch 3 times, most recently from 73cd560 to ebf1645 Compare December 18, 2023 21:28
@avik-pal avik-pal marked this pull request as ready for review December 19, 2023 20:51
@avik-pal
Copy link
Member Author

Once everything is green we should be good to go 🎉

@avik-pal
Copy link
Member Author

I am merging this. No one has direct dependencies on this package and the upgrade should be quite trivial.

@avik-pal avik-pal merged commit 444cd3c into main Dec 20, 2023
9 of 11 checks passed
@avik-pal avik-pal deleted the ap/nlsolve_up branch December 20, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant