Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in Interface #206

Open
sathvikbhagavan opened this issue Nov 16, 2023 · 0 comments
Open

Inconsistency in Interface #206

sathvikbhagavan opened this issue Nov 16, 2023 · 0 comments

Comments

@sathvikbhagavan
Copy link
Member

sathvikbhagavan commented Nov 16, 2023

All methods can take in a Vector of numbers, few methods take in Matrices, Vector of Vectors etc. We should have a consistent interface for all or document this API, reason for it etc.

Methods which can take in Matrices:

  1. LinearInterpolation - https://github.com/SciML/DataInterpolations.jl/blob/master/src/interpolation_methods.jl#L27C26-L27C45
  2. QuadraticInterpolation - https://github.com/SciML/DataInterpolations.jl/blob/master/src/interpolation_methods.jl#L50C26-L50C48
  3. LagrangeInterpolation - https://github.com/SciML/DataInterpolations.jl/blob/master/src/interpolation_methods.jl#L88C26-L88C47
  4. ConstantInterpolation - https://github.com/SciML/DataInterpolations.jl/blob/master/src/interpolation_methods.jl#L146C26-L146C47

So, AkimaInterpolation, QuadraticSpline, CubicSpline, BSplineInterpolation, BSplineApprox does not work with Matrices

Methods which does not work with Vector of Vectors:

AkimaInterpolation, BSplineInterpolation, BSplineApprox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant