fix: disable special colors when in vscode dark mode #152
Conversation
| @@ -0,0 +1,13 @@ | |||
| :root { | |||
| --sca-font-color0: var(--jp-content-font-color0); | |||
There was a problem hiding this comment.
Can you change the prefix to cean? I used that for the HTML classes.
jokasimr
force-pushed
the
colors-in-html-repl
branch
from
9da6749
to
88908e2
Compare
jokasimr
force-pushed
the
colors-in-html-repl
branch
from
88908e2
to
c8f21f2
Compare
| @lru_cache(maxsize=1) | ||
| def dataset_style() -> str: | ||
| sheet = _preprocess_style(_read_text("dataset.css", "styles")) | ||
| return f"<style>{sheet}</style>" | ||
| return f"{common_style()}<style>{sheet}</style>" |
There was a problem hiding this comment.
Can you just merge them into a single <style> tag?
| --cean-font-color3: var(--jp-content-font-color3); | ||
| } | ||
|
|
||
| body.vscode-dark { |
|
Can you add a release note? |
jokasimr
force-pushed
the
colors-in-html-repl
branch
from
c8f21f2
to
fc1763c
Compare
|
This change doesn't do anything about the light background in the sphinx output. Haven't implemented any special case for pycharm either. |
jokasimr
force-pushed
the
colors-in-html-repl
branch
from
fc1763c
to
7842201
Compare
|
I've checked the different platforms (Jupyter, Vscode, Pycharm, Sphinx docs) and they are readable in dark and light mode. Pycharm and sphinx don't use custom font colors (e.g. for missing values etc). I think this can be merged now. |
There was a problem hiding this comment.
Can you place comments that explain the different selectors? In particular the distinction between data-theme and data-jp-theme-light.
There was a problem hiding this comment.
Good question 🤔
data-theme is commonly used to toggle between dark and light mode, in particular it is used to toggle dark/light mode in the Sphinx docs.
However, since the pydata sphinx theme disables dark mode for notebook output it is not used. So perhaps better to remove it?
data-jp-theme-light is used by Jupyter to toggle between dark and light mode.
jokasimr
force-pushed
the
colors-in-html-repl
branch
2 times, most recently
from
0e42c26
to
b0b8145
Compare
jokasimr
force-pushed
the
colors-in-html-repl
branch
from
b0b8145
to
773b4e4
Compare
Part of #87
Currently all this does is
--jp-content-font-colorvariable with a custom--sca-font-colorvariableTo fix this we should figure out: