Fix type hints #125
Fix type hints #125
Conversation
| @@ -396,7 +398,7 @@ def _get_or_add_orig_datablock(self, key: Union[int, str]) -> OrigDatablock: | |||
|
|
|||
| def make_upload_model(self) -> Union[UploadDerivedDataset, UploadRawDataset]: | |||
There was a problem hiding this comment.
Can UploadDerivedDataset and UploadRawDataset be TypeVar instead?
If the model is Type[UploadRawDataset], the returned model is UploadRawDataset for example, right...?
There was a problem hiding this comment.
But this method doesn't take any arguments except self. So how would you match the type of the model?
There was a problem hiding this comment.
Oh Sorry I thought the model was also an input. Never mind...
| @@ -86,7 +88,7 @@ def to_local(self) -> PurePath: | |||
|
|
|||
| def __truediv__(self, other: Union[str, RemotePath]) -> RemotePath: | |||
| """Join two path segments.""" | |||
| if isinstance(other, (PurePath, Path)): | |||
| if isinstance(other, (PurePath, Path)): # type: ignore[unreachable] | |||
| raise TypeError("OS paths are not supported when concatenating RemotePath.") | |||
There was a problem hiding this comment.
I have a question how a type-checker would decide unreachable...
will this line below will also be considered unreachable...?
if not isinstance(other, (str, RemotePath)) and isinstance(other, (PurePath, Path)):
raise ...
There was a problem hiding this comment.
I guess so. It must be based on the argument type hints. And mypy then assumes that no invalid type is ever passed in.
No description provided.