Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/429 angular 16 #439

Merged
merged 6 commits into from
Jun 8, 2023
Merged

Issue/429 angular 16 #439

merged 6 commits into from
Jun 8, 2023

Conversation

Marcarrian
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added
  • Docs have been added or updated

PR Type

What kind of change does this PR introduce?

  • Fix
  • Feature
  • Documentation
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Performance (changes that improve performance)
  • Test (adding missing tests, refactoring tests; no production code change)
  • Chore (other changes like formatting, updating the license, removal of deprecations, etc)
  • Deps (changes related to updating dependencies)
  • CI (changes to our CI configuration files and scripts)
  • Revert (revert of a previous commit)
  • Release (publish a new release)
  • Other... Please describe:

Issue

Issue Number: #429

Does this PR introduce a breaking change?

  • Yes
  • No

@Marcarrian Marcarrian requested a review from danielwiehl June 6, 2023 08:38
@Marcarrian Marcarrian force-pushed the issue/429-angular-16 branch from 52e8209 to 8ae1783 Compare June 7, 2023 07:20
@danielwiehl danielwiehl force-pushed the issue/429-angular-16 branch 2 times, most recently from a0486f9 to b3e5695 Compare June 7, 2023 10:47
@Marcarrian Marcarrian force-pushed the issue/429-angular-16 branch 7 times, most recently from e7b24e8 to c4dbed0 Compare June 8, 2023 09:33
Marcarrian added 6 commits June 8, 2023 14:45
@Marcarrian @danielwiehl
deps(workbench): update @scion/workbench to Angular 16
148134d 
closes #429

BREAKING CHANGE: Updating `@scion/workbench` to Angular 16 introduced a breaking change.

To migrate:
- update your application to Angular 16.x; for detailed migration instructions, refer to https://v16.angular.io/guide/update-to-latest-version;
- update @scion/components to version 16; for detailed migration instructions, refer to https://github.com/SchweizerischeBundesbahnen/scion-toolkit/blob/master/CHANGELOG_COMPONENTS.md;
@Marcarrian @danielwiehl
chore(workbench): remove compatibility of deprecated router API
d1d0ebe 
relates to #239

BREAKING CHANGE: Removing compatibility of deprecated router API introduced a breaking change in client applications.

To migrate applications using @scion/workbench-client:
- update @scion/workbench-client to version `1.0.0-beta.17` or greater
@Marcarrian @danielwiehl
feat(workbench): comply with basic accessibility rules
ab0623e
@Marcarrian @danielwiehl
feat(workbench): mark required inputs as required
00cb27e
@Marcarrian @danielwiehl
feat(workbench): accept passing undefined in optional inputs
eca4b34
@Marcarrian @danielwiehl
refactor(workbench): migrate to takeUntilDestroyed operator
8aa7da3
@danielwiehl danielwiehl force-pushed the issue/429-angular-16 branch from c4dbed0 to 8aa7da3 Compare June 8, 2023 12:47
@danielwiehl danielwiehl merged commit 1a3a9cf into master Jun 8, 2023
@danielwiehl danielwiehl deleted the issue/429-angular-16 branch June 8, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielwiehl danielwiehl danielwiehl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marcarrian @danielwiehl