Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/246 #279

Merged
merged 2 commits into from
Jul 9, 2021
Merged

Issue/246 #279

merged 2 commits into from
Jul 9, 2021

Conversation

mofogasy
Copy link
Contributor

@mofogasy mofogasy commented May 21, 2021 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added
  • Docs have been added or updated

PR Type

What kind of change does this PR introduce?

  • Fix
  • Feature
  • Documentation
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Performance (changes that improve performance)
  • Test (adding missing tests, refactoring tests; no production code change)
  • Chore (other changes like formatting, updating the license, updating dependencies, removal of deprecations, etc)
  • CI (changes to our CI configuration files and scripts)
  • Revert (revert of a previous commit)
  • Release (publish a new release)
  • Other... Please describe:

Issue

Issue Number: #246, #277

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mofogasy mofogasy requested a review from danielwiehl May 21, 2021 15:20
@mofogasy mofogasy force-pushed the issue/246 branch 3 times, most recently from 62d2d58 to 3e9a0ca Compare May 28, 2021 14:05
danielwiehl
danielwiehl approved these changes Jul 9, 2021
View reviewed changes
Copy link
Collaborator

@danielwiehl danielwiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielwiehl danielwiehl merged commit 2f26260 into master Jul 9, 2021
@danielwiehl danielwiehl deleted the issue/246 branch July 9, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielwiehl danielwiehl danielwiehl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mofogasy @danielwiehl