Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkbenchPopup overlaps Messagebox #438

Closed
Marcarrian opened this issue Jun 5, 2023 · 0 comments
Closed

WorkbenchPopup overlaps Messagebox #438

Marcarrian opened this issue Jun 5, 2023 · 0 comments
Milestone

Comments

@Marcarrian
Copy link
Collaborator

Describe the bug

A Messagebox opened from a WorkbenchPopup overlaps it.

@k-genov k-genov added this to the 2023-11 milestone Sep 7, 2023
danielwiehl pushed a commit that referenced this issue Jan 17, 2024
A message box is a standardized dialog for presenting a message to the user, such as an info, warning or alert, or for prompting the user for confirmation. The message can be plain text or a component, allowing for structured content or input prompts.

closes #438

BREAKING CHANGE: Consolidation of the MessageBox API has introduced a breaking change.

Refer to the documentation for migration examples: https://github.com/SchweizerischeBundesbahnen/scion-workbench/blob/master/docs/site/howto/how-to-open-message-box.md

To migrate:
- `MessageBoxService` is now `WorkbenchMessageBoxService`.
- `MessageBoxConfig` is now `WorkbenchMessageBoxOptions`.
- Signature of `WorkbenchMessageBoxService#open` method has changed. Pass the message (text or component) as the first argument, not via options object.
- `injector` option has been moved to a top-level property (previously `MessageBoxConfig#componentConstructOptions`).
- `viewContainerRef` option has been removed (no replacement).
- `componentInput` option has been renamed to `inputs` with the type changed to a dictionary. Inputs are now available as input properties in the component, previously via `MessageBox#input` handle.
- `MessageBox` handle has been removed. Configure the message box when opening the message box.
- Registration of custom action handlers has been removed (no replacement).
- Button with the action key 'close' is no longer bound to the escape keystroke.
danielwiehl pushed a commit that referenced this issue Jan 18, 2024
A message box is a standardized dialog for presenting a message to the user, such as an info, warning or alert, or for prompting the user for confirmation. The message can be plain text or a component, allowing for structured content or input prompts.

closes #438

BREAKING CHANGE: Consolidation of the MessageBox API has introduced a breaking change.

Refer to the documentation for migration examples: https://github.com/SchweizerischeBundesbahnen/scion-workbench/blob/master/docs/site/howto/how-to-open-message-box.md

To migrate:
- `MessageBoxService` is now `WorkbenchMessageBoxService`.
- `MessageBoxConfig` is now `WorkbenchMessageBoxOptions`.
- Signature of `WorkbenchMessageBoxService#open` method has changed. Pass the message (text or component) as the first argument, not via options object.
- `injector` option has been moved to a top-level property (previously `MessageBoxConfig#componentConstructOptions`).
- `viewContainerRef` option has been removed (no replacement).
- `componentInput` option has been renamed to `inputs` with the type changed to a dictionary. Inputs are now available as input properties in the component, previously via `MessageBox#input` handle.
- `MessageBox` handle has been removed. Configure the message box when opening the message box.
- Registration of custom action handlers has been removed (no replacement).
- Button with the action key 'close' is no longer bound to the escape keystroke.
danielwiehl pushed a commit that referenced this issue Jan 18, 2024
A message box is a standardized dialog for presenting a message to the user, such as an info, warning or alert, or for prompting the user for confirmation. The message can be plain text or a component, allowing for structured content or input prompts.

closes #438

BREAKING CHANGE: Consolidation of the MessageBox API has introduced a breaking change.

Refer to the documentation for migration examples: https://github.com/SchweizerischeBundesbahnen/scion-workbench/blob/master/docs/site/howto/how-to-open-message-box.md

To migrate:
- `MessageBoxService` is now `WorkbenchMessageBoxService`.
- `MessageBoxConfig` is now `WorkbenchMessageBoxOptions`.
- Signature of `WorkbenchMessageBoxService#open` method has changed. Pass the message (text or component) as the first argument, not via options object.
- `injector` option has been moved to a top-level property (previously `MessageBoxConfig#componentConstructOptions`).
- `viewContainerRef` option has been removed (no replacement).
- `componentInput` option has been renamed to `inputs` with the type changed to a dictionary. Inputs are now available as input properties in the component, previously via `MessageBox#input` handle.
- `MessageBox` handle has been removed. Configure the message box when opening the message box.
- Registration of custom action handlers has been removed (no replacement).
- Pressing the Escape key no longer closes the message box for an action with the 'close' key.
danielwiehl pushed a commit that referenced this issue Jan 18, 2024
A message box is a standardized dialog for presenting a message to the user, such as an info, warning or alert, or for prompting the user for confirmation. The message can be plain text or a component, allowing for structured content or input prompts.

closes #438

BREAKING CHANGE: Consolidation of the MessageBox API has introduced a breaking change.

Refer to the documentation for migration examples: https://github.com/SchweizerischeBundesbahnen/scion-workbench/blob/master/docs/site/howto/how-to-open-message-box.md

To migrate:
- `MessageBoxService` is now `WorkbenchMessageBoxService`.
- `MessageBoxConfig` is now `WorkbenchMessageBoxOptions`.
- Signature of `WorkbenchMessageBoxService#open` method has changed. Pass the message (text or component) as the first argument, not via options object.
- `injector` option has been moved to a top-level property (previously `MessageBoxConfig#componentConstructOptions`).
- `viewContainerRef` option has been removed (no replacement).
- `componentInput` option has been renamed to `inputs` with the type changed to a dictionary. Inputs are now available as input properties in the component, previously via `MessageBox#input` handle.
- `MessageBox` handle has been removed. Configure the message box when opening the message box.
- Registration of custom action handlers has been removed (no replacement).
- Pressing the Escape key no longer closes the message box for an action with the 'close' key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants