Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using sciDimension directive in 'OnPush' change detection context #106

Closed
danielwiehl opened this issue Mar 12, 2019 · 0 comments
Closed

Allow using sciDimension directive in 'OnPush' change detection context #106

danielwiehl opened this issue Mar 12, 2019 · 0 comments
Assignees
@danielwiehl
Labels
comp: workbench

Comments

@danielwiehl
Copy link
Collaborator

Current behavior

If not specifying a timer, the directive only works in 'default' change detection context.

Expected behavior

The directive should also work in 'OnPush' change detection context without having to use a timer.
danielwiehl added a commit that referenced this issue Mar 12, 2019
@danielwiehl
fix: allow using sciDimension directive in 'OnPush' change detectio…
0cbe69c 
…n context

fixes #106

BREAKING CHANGE: Removed input property `useTimer` because no longer required as now working in the context of 'OnPush' change detection context.
@danielwiehl danielwiehl self-assigned this Mar 12, 2019
@simoneggler simoneggler added this to the 0.0.1 milestone Mar 13, 2019
@danielwiehl danielwiehl mentioned this issue Mar 15, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielwiehl danielwiehl

Labels
comp: workbench
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielwiehl @simoneggler