Skip to content

Commit

Permalink
test(workbench-client): do not await page objects since not promise-b…
Browse files Browse the repository at this point in the history
…ased
  • Loading branch information
danielwiehl authored and Marcarrian committed Oct 26, 2023
1 parent ef9ead2 commit 41be222
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export class AngularZoneTestPagePO {
await startPage.clickTestCapability('e2e-test-angular-zone', 'app1');

// Create the page object.
const view = await appPO.view({cssClass: 'e2e-test-angular-zone', viewId: startPage.viewId});
const view = appPO.view({cssClass: 'e2e-test-angular-zone', viewId: startPage.viewId});
await view.waitUntilAttached();
return new AngularZoneTestPagePO(appPO, await view.getViewId());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export class BulkNavigationTestPagePO {
await startPage.clickTestCapability('e2e-test-bulk-navigation', 'app1');

// Create the page object.
const view = await appPO.view({cssClass: 'e2e-test-bulk-navigation', viewId: startPage.viewId});
const view = appPO.view({cssClass: 'e2e-test-bulk-navigation', viewId: startPage.viewId});
await view.waitUntilAttached();
return new BulkNavigationTestPagePO(appPO, await view.getViewId());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ export class InputFieldTestPagePO {
await startPage.clickTestCapability('test-input-field', 'app1');

// Create the page object.
const view = await appPO.view({cssClass: 'test-input-field', viewId: viewId});
const view = appPO.view({cssClass: 'test-input-field', viewId: viewId});
await view.waitUntilAttached();

const outlet = new SciRouterOutletPO(appPO, {name: viewId});
Expand All @@ -93,7 +93,7 @@ export class InputFieldTestPagePO {
await popupOpenerPage.clickOpen();

// Create the page object.
const popup = await appPO.popup({cssClass: 'test-input-field'});
const popup = appPO.popup({cssClass: 'test-input-field'});
await popup.waitUntilAttached();

const outlet = new SciRouterOutletPO(appPO, {cssClass: ['e2e-popup', 'test-input-field']});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class BulkNavigationTestPagePO {
await routerPage.enterTarget(routerPage.viewId);
await routerPage.clickNavigate();

const view = await appPO.view({cssClass: 'e2e-test-bulk-navigation', viewId: routerPage.viewId});
const view = appPO.view({cssClass: 'e2e-test-bulk-navigation', viewId: routerPage.viewId});
await view.waitUntilAttached();
return new BulkNavigationTestPagePO(appPO, await view.getViewId());
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export class InputFieldTestPagePO {
await routerPage.enterCssClass('input-field-test-page');
await routerPage.clickNavigate();

const view = await appPO.view({cssClass: 'input-field-test-page', viewId: routerPage.viewId});
const view = appPO.view({cssClass: 'input-field-test-page', viewId: routerPage.viewId});
await view.waitUntilAttached();

return new InputFieldTestPagePO(view.locate('app-input-field-test-page'), {view});
Expand All @@ -67,7 +67,7 @@ export class InputFieldTestPagePO {
await popupOpenerPage.clickOpen();

// Create the page object.
const popup = await appPO.popup({cssClass: 'input-field-test-page'});
const popup = appPO.popup({cssClass: 'input-field-test-page'});
await popup.waitUntilAttached();

return new InputFieldTestPagePO(popup.locate('app-input-field-test-page'), {popup});
Expand Down

0 comments on commit 41be222

Please sign in to comment.