-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(workbench/dialog): consolidate API for closing a dialog
BREAKING CHANGE: The method `closeWithError` has been removed from the `WorkbenchDialog` handle. Instead pass an `Error` object to the `close` method. ### The following snippets illustrate how a migration could look like: #### Before migration ```ts import {WorkbenchDialog} from '@scion/workbench'; inject(WorkbenchDialog).closeWithError('some error'); ``` #### After migration ```ts import {WorkbenchDialog} from '@scion/workbench'; inject(WorkbenchDialog).close(new Error('some error')); ```
- Loading branch information
1 parent
1f8cedf
commit 40414c4
Showing
3 changed files
with
8 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters