deps(workbench): update @scion/workbench to Angular 17

closes #485 BREAKING CHANGE: Updating `@scion/workbench` to Angular 17 introduced a breaking change. To migrate: - update your application to Angular 17.x; for detailed migration instructions, refer to https://v17.angular.io/guide/update-to-latest-version; - update @scion/components to version 17; for detailed migration instructions, refer to https://github.com/SchweizerischeBundesbahnen/scion-toolkit/blob/master/CHANGELOG_COMPONENTS.md; - `WorkbenchModule#forChild` was deprecated and has been removed; import `WorkbenchModule` or standalone directives directly;
SchweizerischeBundesbahnen · Nov 14, 2023 · 2f5f82f · 2f5f82f
1 parent 056bcde
commit 2f5f82f
Show file tree

Hide file tree

Showing 18 changed files with 8,653 additions and 8,163 deletions.
diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml
@@ -1,7 +1,7 @@
 name: Continuous Integration and Delivery
 on: [ push, pull_request ]
 env:
-  NODE_VERSION: 18.16.0
+  NODE_VERSION: 20.9.0
 jobs:
   install:
     name: 'Installing NPM modules'

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -36,7 +36,7 @@ This section explains how to submit a pull request.
   <summary><strong>Development</strong></summary>
   <br>
 
-Make sure to use Node.js version 18.16.0 for contributing to SCION. We suggest using [Node Version Manager](https://github.com/nvm-sh/nvm) if you need different Node.js versions for other projects.
+Make sure to use Node.js version 20.9.0 for contributing to SCION. We suggest using [Node Version Manager](https://github.com/nvm-sh/nvm) if you need different Node.js versions for other projects.
 
 For development, you can uncomment the section `PATH-OVERRIDE-FOR-DEVELOPMENT` in `tsconfig.json`. This allows running tests or serving applications without having to build dependent modules first.
 

diff --git a/angular.json b/angular.json
@@ -114,11 +114,11 @@
       "prefix": "app",
       "architect": {
         "build": {
-          "builder": "@angular-devkit/build-angular:browser",
+          "builder": "@angular-devkit/build-angular:application",
           "options": {
             "outputPath": "dist/workbench-getting-started-app",
             "index": "apps/workbench-getting-started-app/src/index.html",
-            "main": "apps/workbench-getting-started-app/src/main.ts",
+            "browser": "apps/workbench-getting-started-app/src/main.ts",
             "polyfills": [
               "zone.js"
             ],
@@ -145,7 +145,12 @@
                 "projects/scion/workbench"
               ]
             },
-            "scripts": []
+            "scripts": [],
+            "externalDependencies": [
+              "assets/fonts/scion-workbench-icons.ttf?*",
+              "assets/fonts/scion-workbench-icons.woff?*",
+              "assets/fonts/scion-workbench-icons.svg?*"
+            ]
           },
           "configurations": {
             "production": {
@@ -164,12 +169,9 @@
               "outputHashing": "all"
             },
             "development": {
-              "buildOptimizer": false,
               "optimization": false,
-              "vendorChunk": true,
               "extractLicenses": false,
-              "sourceMap": true,
-              "namedChunks": true
+              "sourceMap": true
             }
           },
           "defaultConfiguration": "production"
@@ -178,10 +180,10 @@
           "builder": "@angular-devkit/build-angular:dev-server",
           "configurations": {
             "production": {
-              "browserTarget": "workbench-getting-started-app:build:production-ci"
+              "buildTarget": "workbench-getting-started-app:build:production-ci"
             },
             "development": {
-              "browserTarget": "workbench-getting-started-app:build:development"
+              "buildTarget": "workbench-getting-started-app:build:development"
             }
           },
           "defaultConfiguration": "development"
@@ -209,11 +211,11 @@
       "prefix": "app",
       "architect": {
         "build": {
-          "builder": "@angular-devkit/build-angular:browser",
+          "builder": "@angular-devkit/build-angular:application",
           "options": {
             "outputPath": "dist/workbench-testing-app",
             "index": "apps/workbench-testing-app/src/index.html",
-            "main": "apps/workbench-testing-app/src/main.ts",
+            "browser": "apps/workbench-testing-app/src/main.ts",
             "polyfills": [
               "zone.js"
             ],
@@ -245,7 +247,12 @@
                 "projects/scion/workbench"
               ]
             },
-            "scripts": []
+            "scripts": [],
+            "externalDependencies": [
+              "assets/fonts/scion-workbench-icons.ttf?*",
+              "assets/fonts/scion-workbench-icons.woff?*",
+              "assets/fonts/scion-workbench-icons.svg?*"
+            ]
           },
           "configurations": {
             "production-vercel": {
@@ -316,20 +323,14 @@
               "baseHref": "/subdir/"
             },
             "development": {
-              "buildOptimizer": false,
               "optimization": false,
-              "vendorChunk": true,
               "extractLicenses": false,
-              "sourceMap": true,
-              "namedChunks": true
+              "sourceMap": true
             },
             "development-basehref": {
-              "buildOptimizer": false,
               "optimization": false,
-              "vendorChunk": true,
               "extractLicenses": false,
               "sourceMap": true,
-              "namedChunks": true,
               "baseHref": "/subdir/"
             }
           },
@@ -339,13 +340,13 @@
           "builder": "@angular-devkit/build-angular:dev-server",
           "configurations": {
             "production": {
-              "browserTarget": "workbench-testing-app:build:production-ci"
+              "buildTarget": "workbench-testing-app:build:production-ci"
             },
             "development": {
-              "browserTarget": "workbench-testing-app:build:development"
+              "buildTarget": "workbench-testing-app:build:development"
             },
             "development-basehref": {
-              "browserTarget": "workbench-testing-app:build:development-basehref"
+              "buildTarget": "workbench-testing-app:build:development-basehref"
             }
           },
           "defaultConfiguration": "development"
@@ -373,11 +374,11 @@
       "prefix": "app",
       "architect": {
         "build": {
-          "builder": "@angular-devkit/build-angular:browser",
+          "builder": "@angular-devkit/build-angular:application",
           "options": {
             "outputPath": "dist/workbench-client-testing-app",
             "index": "apps/workbench-client-testing-app/src/index.html",
-            "main": "apps/workbench-client-testing-app/src/main.ts",
+            "browser": "apps/workbench-client-testing-app/src/main.ts",
             "polyfills": [
               "zone.js"
             ],
@@ -447,12 +448,9 @@
               "outputPath": "dist/workbench-client-testing-app-ci"
             },
             "development": {
-              "buildOptimizer": false,
               "optimization": false,
-              "vendorChunk": true,
               "extractLicenses": false,
-              "sourceMap": true,
-              "namedChunks": true
+              "sourceMap": true
             }
           },
           "defaultConfiguration": "development"
@@ -461,10 +459,10 @@
           "builder": "@angular-devkit/build-angular:dev-server",
           "configurations": {
             "production": {
-              "browserTarget": "workbench-client-testing-app:build:production-vercel"
+              "buildTarget": "workbench-client-testing-app:build:production-vercel"
             },
             "development": {
-              "browserTarget": "workbench-client-testing-app:build:development"
+              "buildTarget": "workbench-client-testing-app:build:development"
             }
           },
           "defaultConfiguration": "development"
@@ -494,13 +492,5 @@
         }
       }
     }
-  },
-  "schematics": {
-    "@angular-eslint/schematics:application": {
-      "setParserOptionsProject": true
-    },
-    "@angular-eslint/schematics:library": {
-      "setParserOptionsProject": true
-    }
   }
 }