-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(OnyxMoreList): implement more indicator #2133
Conversation
🦋 Changeset detectedLatest commit: 298e285 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/sit-onyx/src/components/OnyxMoreList/OnyxMoreList.vue
Dismissed
Show resolved
Hide resolved
4d9e984
to
ca91f3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is generally fine, but I think using directives instead of refs would make things simpler.
9e96f44
to
cd1b721
Compare
c60c602
to
f62716c
Compare
f62716c
to
79724cb
Compare
Relates to #986
Implement more indicator for OnyxMoreList. For local testing, run Storybook and open:
http://localhost:6006/?path=/story/support-morelist--default
Checklist
npx changeset add
if your changes should be released as npm package (because they affect the library usage)