Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OnyxMoreList): implement more indicator #2133

Merged
merged 23 commits into from
Dec 4, 2024

Conversation

larsrickert
Copy link
Collaborator

@larsrickert larsrickert commented Nov 21, 2024

Relates to #986

Implement more indicator for OnyxMoreList. For local testing, run Storybook and open:
http://localhost:6006/?path=/story/support-morelist--default

Checklist

  • The added / edited code has been documented with JSDoc
  • If a new component is added, at least one Playwright screenshot test is added
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: 298e285

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
sit-onyx Major
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Major
@sit-onyx/nuxt Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@larsrickert larsrickert changed the title [DRAFT] feat(OnyxMoreList): support more indicator feat(OnyxMoreList): implement more indicator Nov 22, 2024
@larsrickert larsrickert force-pushed the feat/986-more-list-indicator branch from 4d9e984 to ca91f3f Compare November 22, 2024 13:35
@larsrickert larsrickert marked this pull request as ready for review November 22, 2024 13:35
@larsrickert larsrickert requested a review from a team as a code owner November 22, 2024 13:35
@JoCa96 JoCa96 self-assigned this Nov 25, 2024
Copy link
Collaborator

@JoCa96 JoCa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is generally fine, but I think using directives instead of refs would make things simpler.

packages/sit-onyx/src/composables/useResizeObserver.ts Outdated Show resolved Hide resolved
packages/sit-onyx/src/composables/useResizeObserver.ts Outdated Show resolved Hide resolved
packages/sit-onyx/src/composables/useResizeObserver.ts Outdated Show resolved Hide resolved
packages/sit-onyx/src/composables/useMoreList.ts Outdated Show resolved Hide resolved
packages/sit-onyx/src/composables/useMoreList.ts Outdated Show resolved Hide resolved
@larsrickert larsrickert force-pushed the feat/986-more-list-indicator branch from 9e96f44 to cd1b721 Compare November 25, 2024 14:58
@larsrickert larsrickert force-pushed the feat/986-more-list-indicator branch 3 times, most recently from c60c602 to f62716c Compare December 3, 2024 10:05
@larsrickert larsrickert force-pushed the feat/986-more-list-indicator branch from f62716c to 79724cb Compare December 4, 2024 07:05
@larsrickert larsrickert enabled auto-merge (squash) December 4, 2024 07:07
@larsrickert larsrickert merged commit 6730706 into main Dec 4, 2024
19 checks passed
@larsrickert larsrickert deleted the feat/986-more-list-indicator branch December 4, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants