Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement OnyxMoreList component #2022

Merged
merged 18 commits into from
Nov 6, 2024
Merged

Conversation

larsrickert
Copy link
Collaborator

@larsrickert larsrickert commented Oct 30, 2024

Relates to #986

Implement a generic OnyxMoreList component that can be used to render any list of components with a "+ more" indicator.
I will integrate it in following PRs into the nav bar as well as implementing the positioning of the more indicator which is currently not visible at all.

Checklist

  • The added / edited code has been documented with JSDoc
  • If a new component is added, at least one Playwright screenshot test is added
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

Copy link

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Latest commit: 29c8789

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@larsrickert larsrickert force-pushed the feat/986-nav-bar-more branch from 1a10d7e to d845217 Compare October 30, 2024 06:22
@larsrickert larsrickert force-pushed the feat/986-nav-bar-more branch from f9f4455 to 8f5f3c0 Compare October 30, 2024 11:10
@larsrickert larsrickert changed the title [DRAFT] feat: implement more feature [DRAFT] feat: implement OnyxMore component Oct 30, 2024
@larsrickert larsrickert changed the title [DRAFT] feat: implement OnyxMore component feat: implement OnyxMore component Oct 30, 2024
@larsrickert larsrickert marked this pull request as ready for review October 30, 2024 11:27
@larsrickert larsrickert requested a review from a team as a code owner October 30, 2024 11:27
@larsrickert larsrickert changed the title feat: implement OnyxMore component feat: implement OnyxMoreList component Oct 30, 2024
@MajaZarkova MajaZarkova self-assigned this Oct 31, 2024
@larsrickert larsrickert force-pushed the feat/986-nav-bar-more branch from ccbff04 to a0c2904 Compare November 4, 2024 06:58
@larsrickert larsrickert force-pushed the feat/986-nav-bar-more branch from 9c22fb2 to 29c8789 Compare November 6, 2024 13:30
@MajaZarkova MajaZarkova merged commit 4db5e6d into main Nov 6, 2024
19 checks passed
@MajaZarkova MajaZarkova deleted the feat/986-nav-bar-more branch November 6, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants