Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nuxt): support theming #1528

Merged
merged 4 commits into from
Jul 9, 2024
Merged

feat(nuxt): support theming #1528

merged 4 commits into from
Jul 9, 2024

Conversation

markbrockhoff
Copy link
Member

Relates to #1490

This PR adds the option to easily theme a nuxt project using the onyx module. Specifying the "theme" config option will automatically inject the correct stylesheet.

Checklist

  • The added / edited code has been documented with JSDoc
  • All changes are documented in the documentation app (folder apps/docs)
  • If a new component is added, at least one Playwright screenshot test is added
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

@markbrockhoff markbrockhoff requested a review from a team as a code owner July 8, 2024 14:36
Copy link

changeset-bot bot commented Jul 8, 2024

🦋 Changeset detected

Latest commit: 2e9f8a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sit-onyx/nuxt Minor
docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@larsrickert larsrickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition to the Nuxt module! Thanks for contributing :)

packages/nuxt/src/module.ts Outdated Show resolved Hide resolved
apps/docs/src/development/packages/nuxt.md Show resolved Hide resolved
@larsrickert larsrickert self-assigned this Jul 9, 2024
@larsrickert larsrickert enabled auto-merge (squash) July 9, 2024 09:17
@larsrickert larsrickert merged commit 3385622 into main Jul 9, 2024
19 checks passed
@larsrickert larsrickert deleted the nuxt/support-themes branch July 9, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants