feat(OnyxSelect): Implement truncation for OnyxSelect options #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 233e8e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: MajaZarkova <[email protected]>
BoppLi
reviewed
Jul 8, 2024
BoppLi
reviewed
Jul 8, 2024
BoppLi
requested changes
Jul 8, 2024
BoppLi
requested changes
Jul 8, 2024
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: MajaZarkova <[email protected]>
BoppLi
previously approved these changes
Jul 9, 2024
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: MajaZarkova <[email protected]>
BoppLi
reviewed
Jul 9, 2024
...ages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-truncated--firefox-linux.png
Outdated
Show resolved
Hide resolved
BoppLi
reviewed
Jul 9, 2024
BoppLi
previously approved these changes
Jul 9, 2024
BoppLi
previously approved these changes
Jul 9, 2024
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: MajaZarkova <[email protected]>
BoppLi
approved these changes
Jul 9, 2024
MajaZarkova
deleted the
feat/733-Implement-truncation-for-OnyxSelect-options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #733
Implemented new truncation property using the existing 'TruncationType', which will apply the existing 'onyx-truncation-ellipsis' and 'onyx-truncation-multiline' classes
Checklist
npx changeset addif your changes should be released as npm package (because they affect the library usage)