Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename toast components #1520

Merged
merged 8 commits into from
Jul 6, 2024

Conversation

larsrickert
Copy link
Collaborator

Relates to #1301

As discussed with Jannick, we aligned the naming between UX and dev

Checklist

  • The added / edited code has been documented with JSDoc
  • All changes are documented in the documentation app (folder apps/docs)
  • If a new component is added, at least one Playwright screenshot test is added
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

@larsrickert larsrickert requested a review from a team as a code owner July 5, 2024 08:00
Copy link

changeset-bot bot commented Jul 5, 2024

🦋 Changeset detected

Latest commit: 63d954b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
sit-onyx Major
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Major
@sit-onyx/nuxt Major
@sit-onyx/storybook-utils Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@BoppLi BoppLi self-assigned this Jul 5, 2024
@larsrickert larsrickert requested a review from BoppLi July 5, 2024 08:30
@larsrickert larsrickert merged commit 7b72cbc into main Jul 6, 2024
19 checks passed
@larsrickert larsrickert deleted the refactor/1301-align-toast-with-figma branch July 6, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants