Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): use correct theme for VitePress #1517

Merged
merged 2 commits into from
Jul 5, 2024
Merged

fix(docs): use correct theme for VitePress #1517

merged 2 commits into from
Jul 5, 2024

Conversation

larsrickert
Copy link
Collaborator

@larsrickert larsrickert commented Jul 5, 2024 •
edited by BoppLi
Loading

Relates to #764

Currently our VitePress docs uses the twogo theme which is not correct. It should use the default onyx theme.
This is fixed in this PR. Also the Storybook theme switch now uses dynamic imports for the theme CSS styles

@larsrickert larsrickert requested a review from a team as a code owner July 5, 2024 06:40
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 09f6edf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@larsrickert larsrickert added bug Something isn't working or not shown correctly documentation Improvements or additions to documentation labels Jul 5, 2024
@BoppLi BoppLi self-assigned this Jul 5, 2024
BoppLi
BoppLi previously approved these changes Jul 5, 2024
View reviewed changes
apps/docs/src/development/theming.data.ts Outdated Show resolved Hide resolved
packages/sit-onyx/.storybook/theme-switch.ts Outdated Show resolved Hide resolved
@larsrickert larsrickert requested a review from BoppLi July 5, 2024 06:56
@larsrickert larsrickert enabled auto-merge (squash) July 5, 2024 06:57
@larsrickert larsrickert merged commit d4d35c9 into main Jul 5, 2024
19 checks passed
@larsrickert larsrickert deleted the fix/docs-theme branch July 5, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoppLi BoppLi BoppLi approved these changes

Assignees

@BoppLi BoppLi

Labels
bug Something isn't working or not shown correctly documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larsrickert @BoppLi