feat: replace deprecated nav components #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f16a7c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <[email protected]>
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <[email protected]>
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <[email protected]>
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <[email protected]>
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <[email protected]>
larsrickert
commented
Jul 4, 2024
...mponents/OnyxNavBar/modules/OnyxNavButton/NavButton-mobile-open-children--chromium-linux.png
Outdated
Show resolved
Hide resolved
...playwright/snapshots/components/OnyxNavBar/modules/OnyxUserMenu/User-menu-chromium-linux.png
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxNavBar/modules/OnyxNavItem/OnyxNavItem.stories.ts
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxNavBar/modules/OnyxUserMenu/OnyxUserMenu.stories.ts
Outdated
Show resolved
Hide resolved
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <[email protected]>
MajaZarkova
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1477
refactor navigation components
OnyxFlyoutMenu: rename default slot to optionsOnyxNavItemcomponent is nowOnyxNavButtonwith changed APIOnyxNavItemis now only intended to be used as children for the newOnyxNavButtonOnyxUserMenu: propertyavatarnow only accepts a string, not an objectChecklist
npx changeset addif your changes should be released as npm package (because they affect the library usage)