Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptations for "new" service #316

Merged
merged 4 commits into from
Oct 3, 2017
Merged

Adaptations for "new" service #316

merged 4 commits into from
Oct 3, 2017

Conversation

flothi
Copy link
Collaborator

@flothi flothi commented Oct 2, 2017

Update README.md:
Fixing description on how to install the service

Fixing description on how to install the service
A tiny to script to install and register the service automatically

There is also a possibility to remove the service
@flothi flothi mentioned this pull request Oct 2, 2017
@Schrolli91 Schrolli91 self-requested a review October 3, 2017 06:52
echo "Please adapt your personal boswatch.service-file"
exit 1
fi
else # we want to remove the service
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sollte man evtl auf (r) prüfen? sonst wir bei allem außer i deinstalliert.
Der Anwender rechnet aber nur bei (r) damit.

@flothi
Copy link
Collaborator Author

flothi commented Oct 3, 2017

Vollkommen richtig. Ich bessere da nochmal nach

Adding errorhandling due to wrong input characters
@flothi
Copy link
Collaborator Author

flothi commented Oct 3, 2017

Ich habe das errorhandling für beide Eingaben eingefügt - das sollte es gewesen sein, wenn ich nichts vergessen habe.

@Schrolli91
Copy link
Owner

Da es sich hier um keine Änderung handelt, die die Funktion an sich betrifft, merge ich das ohne großes geteste. Im Falle eine Bugs, kann man ja Problemlos nochmal nachbessern.

Vielen Dank ...

@Schrolli91 Schrolli91 merged commit cfcc12b into develop Oct 3, 2017
@Schrolli91 Schrolli91 deleted the flothi-patch-1 branch October 3, 2017 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants