feat: enable --resolve-engines by default. out of experimental phase! #1265
+125
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 32dd9c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amitdahan
reviewed
Oct 7, 2024
| @@ -11,7 +11,7 @@ concurrency: | |||
| cancel-in-progress: true | |||
|
|
|||
| env: | |||
| RUST_VERSION: "1.78" | |||
| RUST_VERSION: "1.81" | |||
amitdahan
reviewed
Oct 7, 2024
Comment on lines
+16
to
+19
| #[expect( | ||
| clippy::option_option, | ||
| reason = "clap Option<Option<T>> supports --x and --x=value syntaxes" | ||
| )] |
amitdahan
reviewed
Oct 7, 2024
| clippy::option_option, | ||
| reason = "clap Option<Option<T>> supports --x and --x=value syntaxes" | ||
| )] | ||
| resolve_engines: Option<Option<bool>>, |
There was a problem hiding this comment.
Why is it Option<Option<bool>> and not Option<bool>?
There was a problem hiding this comment.
because Option<Option<bool>> means that --resolve-engines will work and so will --resolve-engines=false
There was a problem hiding this comment.
Ugh
So --resolve-engines is Some(None), and --resolve-engines=false is Some(Some(false))?
Schniz
force-pushed
the
merge-experimental-featurse
branch
from
b800899 to
f3c02ff
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @amitdahan for this wonderful feature that is more than 1yr old now