Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CSS declarations which change default scrollbar width #6

Draft
wants to merge 2 commits into
base: sc_v1.11.86
Choose a base branch
from
Draft

Remove CSS declarations which change default scrollbar width #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9759f13
Remove CSS declarations which change default scrollbar width
luixxiul Dec 1, 2024
fe64b85
Address the feedback
luixxiul Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion res/css/structures/_AutoHideScrollbar.pcss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
/*
Copyright 2018-2024 New Vector Ltd.
Copyright 2024 Suguru Hirahara

SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only
Please see LICENSE files in the repository root for full details.
*/

/* make any scrollbar grey and thin */
/* make any scrollbar grey */
html {
scrollbar-color: $scrollbar-thumb-color transparent;
}
/* SC: disabled */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put it right above the actual commented out section, and use the same /*. The first point further reduces merge conflict area, the second one is just matter of taste I guess

/* scrollbar-width is not inherited (but -color is, why?!), */
/* so declare it on every element */
/*
* {
scrollbar-width: thin;
}
Expand All @@ -19,6 +22,7 @@ html {
width: 6px;
height: 6px;
}
*/

::-webkit-scrollbar-thumb {
border-radius: 3px;
Expand Down