Add schema for rust-project.json
#2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/schemas/json/rust-project.json
Outdated
| "properties": { | ||
| "display_name": { | ||
| "type": "string", | ||
| "description": "Crate name used for display purposes, without affecting semantics." |
There was a problem hiding this comment.
Optional fix (multiple issues): add link to official documentation with the following format: "{{your_description}}\n{{link_here}}".
Note: without it I can't quickly check and suggest fixes for your schema.
There was a problem hiding this comment.
The only documentation for this file is this one, which unfortunately doesn't have a lot of information about each property...
|
@EmilySeville7cfg This PR is still a draft (and this is why I haven't added the relevant links) because I'm waiting to get a thumbs up from the |
|
No problem. 😄 |
EmilyGraceSeville7cf
approved these changes
Dec 4, 2022
|
@MariaSolOs |
for more information, see https://pre-commit.ci
|
Thanks |
bors
added a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Dec 9, 2022
Add VS Code schema validation for `rust-project.json` Now that SchemaStore/schemastore#2628 has been merged, adding the `jsonValidation` contribution to the VS Code extension for better editor support when modifying `rust-project.json` files. Related issue: #13714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the schema for
rust-project.json, which is documented here.Note that I also added some extra fields that are not mentioned in the public link above but that are part of the implementation.