Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Schema: Turborepo #2415

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Conversation

hyperupcall
Copy link
Member

Turborepo, a TypeScript/JavaScript monorepo management tool is configured using a turbo.json configuration file. This adds support for that

@GerryFerdinandus
Copy link
Contributor

You need to remove package.json from "skiptest": []
"skiptest": [] is for a schema that should not be validated at all.
So no AJV validation of the schema or test etc.
This is used for schemas that were previously added to schemastore but moved to an external site. And the local schema file should still exist for a possible hardcoded URL link to the schema.
See history of https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/block.json

It is not possible to combine a local and remote schema

@GerryFerdinandus
Copy link
Contributor

Extra information:
in the past the tv4 validator could download an external schema. The downside is that the build server failed randomly because sometimes it can't download the file. The remote download functionality has been removed.

See issue #2247 on external schema not available. But some URLs are permanently broken and others are not.
Why has this download failed in the past?
https://raw.githubusercontent.com/fossas/fossa-cli/master/docs/references/files/fossa-deps.schema.json
The file was not deleted or moved according to history:
https://github.com/fossas/fossa-cli/commits/master/docs/references/files/fossa-deps.schema.json

@hyperupcall
Copy link
Member Author

Ah okay, it looks like I was confused. So some schemas were originally located here, but they moved to an external site, and those schema files were kept here in case their URLs were hardcoded. Now that I think about it, would this be potentially applicable in the case of xunit? That PR was merged before the single source of truth was added to CONTRIBUTING.md, and when I did the PR, I sort of copied the schema files from xunit.net for each of the versions. A mistake, in retrospect, but is that something you would be interested in me fixing (in the same style as block.json / theme-v1.json)?

About Turborepo, since it is not possible to combine a local and external schema, I have updated this PR to only add the external schema to catalog.json. Thank you for the extra information, the use of tv4 validator is interesting, especially since it doesn't seem maintained for 6ish years now.

@GerryFerdinandus GerryFerdinandus merged commit 3a8c293 into SchemaStore:master Aug 14, 2022
@GerryFerdinandus
Copy link
Contributor

yes, for xunit please use the external schema.

tv4 was the first and only validator at the start of this project. Later, an even better AJV validator was added. Schema that fails AJV validation is still used with the deprecated tv4 validator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants